diff options
| author | Steve Grubb <sgrubb@redhat.com> | 2016-11-16 16:14:33 -0500 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2016-11-20 15:38:00 -0500 |
| commit | c1e8f06d7a0eea232ce0767471e1b4756ccab70a (patch) | |
| tree | 5b33f318b333b8bf61e2f24f9767bc977b2c261e /kernel/audit_watch.c | |
| parent | 833fc48d18ce3595990b405ae82a160b33028994 (diff) | |
| download | lwn-c1e8f06d7a0eea232ce0767471e1b4756ccab70a.tar.gz lwn-c1e8f06d7a0eea232ce0767471e1b4756ccab70a.zip | |
audit: fix formatting of AUDIT_CONFIG_CHANGE events
The AUDIT_CONFIG_CHANGE events sometimes use a op= field. The current
code logs the value of the field with quotes. This field is documented
to not be encoded, so it should not have quotes.
Signed-off-by: Steve Grubb <sgrubb@redhat.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
[PM: reformatted commit description to make checkpatch.pl happy]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'kernel/audit_watch.c')
| -rw-r--r-- | kernel/audit_watch.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c index 0d302a87f21b..686e068ec3da 100644 --- a/kernel/audit_watch.c +++ b/kernel/audit_watch.c @@ -242,10 +242,9 @@ static void audit_watch_log_rule_change(struct audit_krule *r, struct audit_watc ab = audit_log_start(NULL, GFP_NOFS, AUDIT_CONFIG_CHANGE); if (unlikely(!ab)) return; - audit_log_format(ab, "auid=%u ses=%u op=", + audit_log_format(ab, "auid=%u ses=%u op=%s", from_kuid(&init_user_ns, audit_get_loginuid(current)), - audit_get_sessionid(current)); - audit_log_string(ab, op); + audit_get_sessionid(current), op); audit_log_format(ab, " path="); audit_log_untrustedstring(ab, w->path); audit_log_key(ab, r->filterkey); |