diff options
| author | Richard Guy Briggs <rgb@redhat.com> | 2016-01-25 18:04:15 -0500 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2016-01-25 18:04:15 -0500 |
| commit | 935c9e7ff06abf12c45155f75ec2f712d3768095 (patch) | |
| tree | ac1118ff77239fe8f939c9bfd2afe37cc5c4fa19 /kernel/audit.c | |
| parent | 133e1e5acd4a63c4a0dcc413e90d5decdbce9c4a (diff) | |
| download | lwn-935c9e7ff06abf12c45155f75ec2f712d3768095.tar.gz lwn-935c9e7ff06abf12c45155f75ec2f712d3768095.zip | |
audit: log failed attempts to change audit_pid configuration
Failed attempts to change the audit_pid configuration are not presently
logged. One case is an attempt to starve an old auditd by starting up
a new auditd when the old one is still alive and active. The other
case is an attempt to orphan a new auditd when an old auditd shuts
down.
Log both as AUDIT_CONFIG_CHANGE messages with failure result.
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Diffstat (limited to 'kernel/audit.c')
| -rw-r--r-- | kernel/audit.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/kernel/audit.c b/kernel/audit.c index 2fd63d6879c5..8fa7533bf106 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -882,11 +882,15 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) int new_pid = s.pid; pid_t requesting_pid = task_tgid_vnr(current); - if ((!new_pid) && (requesting_pid != audit_pid)) + if ((!new_pid) && (requesting_pid != audit_pid)) { + audit_log_config_change("audit_pid", new_pid, audit_pid, 0); return -EACCES; + } if (audit_pid && new_pid && - audit_replace(requesting_pid) != -ECONNREFUSED) + audit_replace(requesting_pid) != -ECONNREFUSED) { + audit_log_config_change("audit_pid", new_pid, audit_pid, 0); return -EEXIST; + } if (audit_enabled != AUDIT_OFF) audit_log_config_change("audit_pid", new_pid, audit_pid, 1); audit_pid = new_pid; |