diff options
| author | Eric Paris <eparis@redhat.com> | 2010-04-07 15:15:25 -0400 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2010-04-12 12:19:19 +1000 |
| commit | 05b90496f2f366b9d3eea468351888ddf010782a (patch) | |
| tree | 5c6b3c5167d4577043e74bb8590a6a4ed48c0bdf /kernel/acct.c | |
| parent | 3011a344cdcda34cdbcb40c3fb3d1a6e89954abb (diff) | |
| download | lwn-05b90496f2f366b9d3eea468351888ddf010782a.tar.gz lwn-05b90496f2f366b9d3eea468351888ddf010782a.zip | |
security: remove dead hook acct
Unused hook. Remove.
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'kernel/acct.c')
| -rw-r--r-- | kernel/acct.c | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/kernel/acct.c b/kernel/acct.c index 24f8c81fc48d..9e53bb2acfff 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -216,7 +216,6 @@ static int acct_on(char *name) { struct file *file; struct vfsmount *mnt; - int error; struct pid_namespace *ns; struct bsd_acct_struct *acct = NULL; @@ -244,13 +243,6 @@ static int acct_on(char *name) } } - error = security_acct(file); - if (error) { - kfree(acct); - filp_close(file, NULL); - return error; - } - spin_lock(&acct_lock); if (ns->bacct == NULL) { ns->bacct = acct; @@ -281,7 +273,7 @@ static int acct_on(char *name) */ SYSCALL_DEFINE1(acct, const char __user *, name) { - int error; + int error = 0; if (!capable(CAP_SYS_PACCT)) return -EPERM; @@ -299,13 +291,11 @@ SYSCALL_DEFINE1(acct, const char __user *, name) if (acct == NULL) return 0; - error = security_acct(NULL); - if (!error) { - spin_lock(&acct_lock); - acct_file_reopen(acct, NULL, NULL); - spin_unlock(&acct_lock); - } + spin_lock(&acct_lock); + acct_file_reopen(acct, NULL, NULL); + spin_unlock(&acct_lock); } + return error; } |