diff options
author | Nadia Derbey <Nadia.Derbey@bull.net> | 2007-10-18 23:40:53 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-19 11:53:47 -0700 |
commit | f4566f04854d78acfc74b9acb029744acde9d033 (patch) | |
tree | 6fa631076d11511e2d9685b23c195835c31f4900 /ipc/msg.c | |
parent | 28028313134e9f11e49f74a4beaa47c91e5ebf06 (diff) | |
download | lwn-f4566f04854d78acfc74b9acb029744acde9d033.tar.gz lwn-f4566f04854d78acfc74b9acb029744acde9d033.zip |
ipc: fix wrong comments
This patch fixes the wrong / obsolete comments in the ipc code. Also adds
a missing lock around ipc_get_maxid() in shm_get_stat().
Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'ipc/msg.c')
-rw-r--r-- | ipc/msg.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/ipc/msg.c b/ipc/msg.c index 9f545826bcf5..b7274dbf0917 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -156,6 +156,13 @@ static inline void msg_rmid(struct ipc_namespace *ns, struct msg_queue *s) ipc_rmid(&msg_ids(ns), &s->q_perm); } +/** + * newque - Create a new msg queue + * @ns: namespace + * @params: ptr to the structure that contains the key and msgflg + * + * Called with msg_ids.mutex held + */ static int newque(struct ipc_namespace *ns, struct ipc_params *params) { struct msg_queue *msq; @@ -250,8 +257,8 @@ static void expunge_all(struct msg_queue *msq, int res) /* * freeque() wakes up waiters on the sender and receiver waiting queue, - * removes the message queue from message queue ID - * IDR, and cleans up all the messages associated with this queue. + * removes the message queue from message queue ID IDR, and cleans up all the + * messages associated with this queue. * * msg_ids.mutex and the spinlock for this message queue are held * before freeque() is called. msg_ids.mutex remains locked on exit. @@ -278,6 +285,9 @@ static void freeque(struct ipc_namespace *ns, struct msg_queue *msq) ipc_rcu_putref(msq); } +/* + * Called with msg_ids.mutex and ipcp locked. + */ static inline int msg_security(struct kern_ipc_perm *ipcp, int msgflg) { struct msg_queue *msq = container_of(ipcp, struct msg_queue, q_perm); |