summaryrefslogtreecommitdiff
path: root/init
diff options
context:
space:
mode:
authorPeter Malone <peter.malone@gmail.com>2018-03-07 14:00:34 +0100
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2018-03-07 14:00:34 +0100
commit250c6c49e3b68756b14983c076183568636e2bde (patch)
tree0a893a4160c4b68a1240e0c6efad154ed7c8bfdb /init
parent5fe9cfbe44b6892e17f803125c4761221b0175c6 (diff)
downloadlwn-250c6c49e3b68756b14983c076183568636e2bde.tar.gz
lwn-250c6c49e3b68756b14983c076183568636e2bde.zip
fbdev: Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in sbusfb_ioctl_helper().
Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in sbusfb_ioctl_helper(). 'index' is defined as an int in sbusfb_ioctl_helper(). We retrieve this from the user: if (get_user(index, &c->index) || __get_user(count, &c->count) || __get_user(ured, &c->red) || __get_user(ugreen, &c->green) || __get_user(ublue, &c->blue)) return -EFAULT; and then we use 'index' in the following way: red = cmap->red[index + i] >> 8; green = cmap->green[index + i] >> 8; blue = cmap->blue[index + i] >> 8; This is a classic information leak vulnerability. 'index' should be an unsigned int, given its usage above. This patch is straight-forward; it changes 'index' to unsigned int in two switch-cases: FBIOGETCMAP_SPARC && FBIOPUTCMAP_SPARC. This patch fixes CVE-2018-6412. Signed-off-by: Peter Malone <peter.malone@gmail.com> Acked-by: Mathieu Malaterre <malat@debian.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions