diff options
| author | Chen Yu <yu.c.chen@intel.com> | 2015-05-03 22:35:05 +0800 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2015-05-05 12:31:37 -0400 |
| commit | cb31ef485dd4c6a205d1064b42027f82076d00c8 (patch) | |
| tree | fbd2bd34a8ff0fd7990dea514098f304396815b2 /init | |
| parent | c0403ec0bb5a8c5b267fb7e16021bec0b17e4964 (diff) | |
| download | lwn-cb31ef485dd4c6a205d1064b42027f82076d00c8.tar.gz lwn-cb31ef485dd4c6a205d1064b42027f82076d00c8.zip | |
init: fix regression by supporting devices with major:minor:offset format
Commit 283e7ad02 ("init: stricter checking of major:minor root=
values") was so strict that it exposed the fact that a previously
unknown device format was being used.
Distributions like Ubuntu uses klibc (rather than uswsusp) to resume
system from hibernation. klibc expressed the swap partition/file in
the form of major:minor:offset. For example, 8:3:0 represents a swap
partition in klibc, and klibc's resume process in initrd will finally
echo 8:3:0 to /sys/power/resume for manually resuming. However, due
to commit 283e7ad02's stricter checking, 8:3:0 will be treated as an
invalid device format, and manual resuming from hibernation will fail.
Fix this by adding support for devices with major:minor:offset format
when resuming from hibernation.
Reported-by: Prigent, Christophe <christophe.prigent@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
Acked-by: Rafael J. Wysocki <rjw@rjwysocki.net>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'init')
| -rw-r--r-- | init/do_mounts.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/init/do_mounts.c b/init/do_mounts.c index 8369ffa5f33d..a95bbdb2a502 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c @@ -225,10 +225,11 @@ dev_t name_to_dev_t(const char *name) #endif if (strncmp(name, "/dev/", 5) != 0) { - unsigned maj, min; + unsigned maj, min, offset; char dummy; - if (sscanf(name, "%u:%u%c", &maj, &min, &dummy) == 2) { + if ((sscanf(name, "%u:%u%c", &maj, &min, &dummy) == 2) || + (sscanf(name, "%u:%u:%u:%c", &maj, &min, &offset, &dummy) == 3)) { res = MKDEV(maj, min); if (maj != MAJOR(res) || min != MINOR(res)) goto fail; |