diff options
author | Zhengyu He <hzy@google.com> | 2014-07-01 12:11:47 -0700 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2014-07-01 16:45:22 -0400 |
commit | 330d282216d6e4d845a21b72572dc4df4122e8fa (patch) | |
tree | 6dd8b6bff8792e29a07acd8a641bb945b67ca4bd /init | |
parent | ebe06187bf2aec10d537ce4595e416035367d703 (diff) | |
download | lwn-330d282216d6e4d845a21b72572dc4df4122e8fa.tar.gz lwn-330d282216d6e4d845a21b72572dc4df4122e8fa.zip |
core: fix typo in percpu read_mostly section
This fixes a typo that named the read_mostly section of percpu as
readmostly. It works fine with SMP because the linker script specifies
.data..percpu..readmostly. However, UP kernel builds don't have percpu
sections defined and the non-percpu version of the section is called
data..read_mostly, so .data..readmostly will float around and may break
things unexpectedly.
Looking at the original change that introduced data..percpu..readmostly
(commit c957ef2c59e952803766ddc22e89981ab534606f), it looks like this
was the original intention.
Tested: Built UP kernel and confirmed the sections got merged.
- Before the patch:
$ objdump -h vmlinux.o | grep '\.data\.\.read.*mostly'
38 .data..read_mostly 00004418 0000000000000000 0000000000000000 00431ac0 2**6
50 .data..readmostly 00000014 0000000000000000 0000000000000000 00444000 2**3
- After the patch:
$ objdump -h vmlinux.o | grep '\.data\.\.read.*mostly'
38 .data..read_mostly 00004438 0000000000000000 0000000000000000 00431ac0 2**6
Signed-off-by: Zhengyu He <hzy@google.com>
Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions