diff options
| author | Christoph Hellwig <hch@lst.de> | 2020-06-27 09:31:57 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-06-29 09:09:08 -0600 |
| commit | 93b8063804b62b55248e16499d853e1b20eff905 (patch) | |
| tree | 4bf81072242d6dfcc2e4e70fad9b83cfb52ad7b8 /include | |
| parent | 7582f30cc9fbcdcd630398bea010e5f6a2e2fcab (diff) | |
| download | lwn-93b8063804b62b55248e16499d853e1b20eff905.tar.gz lwn-93b8063804b62b55248e16499d853e1b20eff905.zip | |
blk-cgroup: move rcu locking from blkcg_bio_issue_check to blk_throtl_bio
The only thing in blkcg_bio_issue_check that needs to be under
rcu_read_lock is blk_throtl_bio, so move the locking there.
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/blk-cgroup.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 8e86b598316c..8ab043c911f2 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -546,7 +546,6 @@ static inline bool blkcg_bio_issue_check(struct request_queue *q, struct blkcg_gq *blkg = bio->bi_blkg; bool throtl = false; - rcu_read_lock(); throtl = blk_throtl_bio(q, blkg, bio); if (!throtl) { struct blkg_iostat_set *bis; @@ -582,7 +581,6 @@ static inline bool blkcg_bio_issue_check(struct request_queue *q, blkcg_bio_issue_init(bio); - rcu_read_unlock(); return !throtl; } |