diff options
| author | Tejun Heo <tj@kernel.org> | 2014-07-03 15:43:15 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-07-06 18:49:20 -0700 |
| commit | e3293b8639a90b7227be9c273af0a45015c499bb (patch) | |
| tree | f6e8281c21358eb0ad7666a1b78b03547f48aaba /include | |
| parent | 60db34152db66ac6e6b6e12c1d7229179ff4711a (diff) | |
| download | lwn-e3293b8639a90b7227be9c273af0a45015c499bb.tar.gz lwn-e3293b8639a90b7227be9c273af0a45015c499bb.zip | |
ptrace,x86: force IRET path after a ptrace_stop()
commit b9cd18de4db3c9ffa7e17b0dc0ca99ed5aa4d43a upstream.
The 'sysret' fastpath does not correctly restore even all regular
registers, much less any segment registers or reflags values. That is
very much part of why it's faster than 'iret'.
Normally that isn't a problem, because the normal ptrace() interface
catches the process using the signal handler infrastructure, which
always returns with an iret.
However, some paths can get caught using ptrace_event() instead of the
signal path, and for those we need to make sure that we aren't going to
return to user space using 'sysret'. Otherwise the modifications that
may have been done to the register set by the tracer wouldn't
necessarily take effect.
Fix it by forcing IRET path by setting TIF_NOTIFY_RESUME from
arch_ptrace_stop_needed() which is invoked from ptrace_stop().
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Andy Lutomirski <luto@amacapital.net>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/ptrace.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h index 5c719627c2aa..ed12724901bc 100644 --- a/include/linux/ptrace.h +++ b/include/linux/ptrace.h @@ -379,6 +379,9 @@ static inline void user_single_step_siginfo(struct task_struct *tsk, * calling arch_ptrace_stop() when it would be superfluous. For example, * if the thread has not been back to user mode since the last stop, the * thread state might indicate that nothing needs to be done. + * + * This is guaranteed to be invoked once before a task stops for ptrace and + * may include arch-specific operations necessary prior to a ptrace stop. */ #define arch_ptrace_stop_needed(code, info) (0) #endif |