diff options
author | Andrey Grodzovsky <andrey2805@gmail.com> | 2016-06-21 14:26:36 -0400 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2016-08-22 22:38:18 +0100 |
commit | 0993de3256271f11b8a4bb48e29bfdc842cf7d98 (patch) | |
tree | f4df1031491148201300d70704df60cff87ab9f0 /include | |
parent | c47cdc38adea0c9b67a20c017c87f9e946ddb874 (diff) | |
download | lwn-0993de3256271f11b8a4bb48e29bfdc842cf7d98.tar.gz lwn-0993de3256271f11b8a4bb48e29bfdc842cf7d98.zip |
xen/pciback: Fix conf_space read/write overlap check.
commit 02ef871ecac290919ea0c783d05da7eedeffc10e upstream.
Current overlap check is evaluating to false a case where a filter
field is fully contained (proper subset) of a r/w request. This
change applies classical overlap check instead to include all the
scenarios.
More specifically, for (Hilscher GmbH CIFX 50E-DP(M/S)) device driver
the logic is such that the entire confspace is read and written in 4
byte chunks. In this case as an example, CACHE_LINE_SIZE,
LATENCY_TIMER and PCI_BIST are arriving together in one call to
xen_pcibk_config_write() with offset == 0xc and size == 4. With the
exsisting overlap check the LATENCY_TIMER field (offset == 0xd, length
== 1) is fully contained in the write request and hence is excluded
from write, which is incorrect.
Signed-off-by: Andrey Grodzovsky <andrey2805@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions