diff options
| author | Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com> | 2014-11-13 13:47:26 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-12-06 15:05:46 -0800 |
| commit | 07729b8d98ea785c58acf3272fe875e44daeb260 (patch) | |
| tree | f28e14cca12ae703e9c8953088d921eb4d644337 /include | |
| parent | a1b9c49bd036057cd4f2cfc9a97fd64d8b830deb (diff) | |
| download | lwn-07729b8d98ea785c58acf3272fe875e44daeb260.tar.gz lwn-07729b8d98ea785c58acf3272fe875e44daeb260.zip | |
inetdevice: fixed signed integer overflow
[ Upstream commit 84bc88688e3f6ef843aa8803dbcd90168bb89faf ]
There could be a signed overflow in the following code.
The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.
Signed-off-by: Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/inetdevice.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h index ea1e3b863890..770ecc90993b 100644 --- a/include/linux/inetdevice.h +++ b/include/linux/inetdevice.h @@ -261,7 +261,7 @@ static inline void in_dev_put(struct in_device *idev) static __inline__ __be32 inet_make_mask(int logmask) { if (logmask) - return htonl(~((1<<(32-logmask))-1)); + return htonl(~((1U<<(32-logmask))-1)); return 0; } |