diff options
| author | Olga Kornievskaia <aglo@umich.edu> | 2015-09-14 19:54:36 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:06:20 -0800 |
| commit | 59ae7b1c13bd615b09bff9d03aaa335559af604a (patch) | |
| tree | 00760678a23a92fc6f63573f48d24a8b2171284e /include | |
| parent | 4c67196fd14f5f53eb865719bfca1908fa963618 (diff) | |
| download | lwn-59ae7b1c13bd615b09bff9d03aaa335559af604a.tar.gz lwn-59ae7b1c13bd615b09bff9d03aaa335559af604a.zip | |
Failing to send a CLOSE if file is opened WRONLY and server reboots on a 4.x mount
commit a41cbe86df3afbc82311a1640e20858c0cd7e065 upstream.
A test case is as the description says:
open(foobar, O_WRONLY);
sleep() --> reboot the server
close(foobar)
The bug is because in nfs4state.c in nfs4_reclaim_open_state() a few
line before going to restart, there is
clear_bit(NFS4CLNT_RECLAIM_NOGRACE, &state->flags).
NFS4CLNT_RECLAIM_NOGRACE is a flag for the client states not open
owner states. Value of NFS4CLNT_RECLAIM_NOGRACE is 4 which is the
value of NFS_O_WRONLY_STATE in nfs4_state->flags. So clearing it wipes
out state and when we go to close it, “call_close” doesn’t get set as
state flag is not set and CLOSE doesn’t go on the wire.
Signed-off-by: Olga Kornievskaia <aglo@umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions