diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2009-10-09 12:43:12 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-22 15:11:49 -0700 |
| commit | dd02f3999f68aadaf7b3e61586fda3f5caac3ead (patch) | |
| tree | e975a59fad89b9a61968fd8eb8163a2b5d1c86e2 /include | |
| parent | f33206c1e3c1a34ba76d9a009a0bdde63ef9248d (diff) | |
| download | lwn-dd02f3999f68aadaf7b3e61586fda3f5caac3ead.tar.gz lwn-dd02f3999f68aadaf7b3e61586fda3f5caac3ead.zip | |
USB: serial: don't call release without attach
commit a4720c650b68a5fe7faed2edeb0ad12645f7ae63 upstream.
This patch (as1295) fixes a recently-added bug in the USB serial core.
If certain kinds of errors occur during probing, the core may call a
serial driver's release method without previously calling the attach
method. This causes some drivers (io_ti in particular) to perform an
invalid memory access.
The patch adds a new flag to keep track of whether or not attach has
been called.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Jean-Denis Girard <jd.girard@sysnux.pf>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/usb/serial.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h index 73f121ef4de0..20b12f3207ae 100644 --- a/include/linux/usb/serial.h +++ b/include/linux/usb/serial.h @@ -148,6 +148,7 @@ struct usb_serial { struct usb_interface *interface; unsigned char disconnected:1; unsigned char suspending:1; + unsigned char attached:1; unsigned char minor; unsigned char num_ports; unsigned char num_port_pointers; |