diff options
| author | Taehee Yoo <ap420073@gmail.com> | 2019-01-09 02:24:53 +0900 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-11 18:05:41 -0800 |
| commit | 61fbf5933d42b02f552123af5a87a06335a3b4db (patch) | |
| tree | b7e58c69a150b8624bb32c4f28cea3de3e1fcedd /include | |
| parent | 5b4cb650e569db2e6a09d2fa0ef8eb789a0ac5d8 (diff) | |
| download | lwn-61fbf5933d42b02f552123af5a87a06335a3b4db.tar.gz lwn-61fbf5933d42b02f552123af5a87a06335a3b4db.zip | |
net: bpfilter: restart bpfilter_umh when error occurred
The bpfilter_umh will be stopped via __stop_umh() when the bpfilter
error occurred.
The bpfilter_umh() couldn't start again because there is no restart
routine.
The section of the bpfilter_umh_{start/end} is no longer .init.rodata
because these area should be reused in the restart routine. hence
the section name is changed to .bpfilter_umh.
The bpfilter_ops->start() is restart callback. it will be called when
bpfilter_umh is stopped.
The stop bit means bpfilter_umh is stopped. this bit is set by both
start and stop routine.
Before this patch,
Test commands:
$ iptables -vnL
$ kill -9 <pid of bpfilter_umh>
$ iptables -vnL
[ 480.045136] bpfilter: write fail -32
$ iptables -vnL
All iptables commands will fail.
After this patch,
Test commands:
$ iptables -vnL
$ kill -9 <pid of bpfilter_umh>
$ iptables -vnL
$ iptables -vnL
Now, all iptables commands will work.
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/bpfilter.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/bpfilter.h b/include/linux/bpfilter.h index 70ffeed280e9..8ebcbdd70bdc 100644 --- a/include/linux/bpfilter.h +++ b/include/linux/bpfilter.h @@ -15,6 +15,8 @@ struct bpfilter_umh_ops { int (*sockopt)(struct sock *sk, int optname, char __user *optval, unsigned int optlen, bool is_set); + int (*start)(void); + bool stop; }; extern struct bpfilter_umh_ops bpfilter_ops; #endif |