diff options
| author | Florent Fourcot <florent.fourcot@wifirst.fr> | 2018-08-30 16:39:23 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-02 13:57:12 -0700 |
| commit | b9de3963cc2b373a655636335cb8c4ed12fc9d3b (patch) | |
| tree | dce21010f7b32f5a83b1a484839178ec362304e6 /include/uapi/linux/pkt_sched.h | |
| parent | 2d5c2885983996ae5c32585b16bc600da7aa17bc (diff) | |
| download | lwn-b9de3963cc2b373a655636335cb8c4ed12fc9d3b.tar.gz lwn-b9de3963cc2b373a655636335cb8c4ed12fc9d3b.zip | |
net/sched: fix type of htb statistics
tokens and ctokens are defined as s64 in htb_class structure,
and clamped to 32bits value during netlink dumps:
cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
INT_MIN, INT_MAX);
Defining it as u32 is working since userspace (tc) is printing it as
signed int, but a correct definition from the beginning is probably
better.
In the same time, 'giants' structure member is unused since years, so
update the comment to mark it unused.
Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/pkt_sched.h')
| -rw-r--r-- | include/uapi/linux/pkt_sched.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 8975fd1a1421..e9b7244ac381 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -395,9 +395,9 @@ enum { struct tc_htb_xstats { __u32 lends; __u32 borrows; - __u32 giants; /* too big packets (rate will not be accurate) */ - __u32 tokens; - __u32 ctokens; + __u32 giants; /* unused since 'Make HTB scheduler work with TSO.' */ + __s32 tokens; + __s32 ctokens; }; /* HFSC section */ |