diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2013-11-24 21:09:26 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-28 18:26:30 -0500 |
| commit | 5e53e689b737526308db2b5c9f56e9d0371a1676 (patch) | |
| tree | 933490eed9b4751978bb9d469d6afb6013646a8d /include/uapi/linux/genetlink.h | |
| parent | 0f0e2159c0c101426b705d70f43b9f423d51c869 (diff) | |
| download | lwn-5e53e689b737526308db2b5c9f56e9d0371a1676.tar.gz lwn-5e53e689b737526308db2b5c9f56e9d0371a1676.zip | |
genetlink/pmcraid: use proper genetlink multicast API
The pmcraid driver is abusing the genetlink API and is using its
family ID as the multicast group ID, which is invalid and may
belong to somebody else (and likely will.)
Make it use the correct API, but since this may already be used
as-is by userspace, reserve a family ID for this code and also
reserve that group ID to not break userspace assumptions.
My previous patch broke event delivery in the driver as I missed
that it wasn't using the right API and forgot to update it later
in my series.
While changing this, I noticed that the genetlink code could use
the static group ID instead of a strcmp(), so also do that for
the VFS_DQUOT family.
Cc: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/genetlink.h')
| -rw-r--r-- | include/uapi/linux/genetlink.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h index 1af72d8228e0..c3363ba1ae05 100644 --- a/include/uapi/linux/genetlink.h +++ b/include/uapi/linux/genetlink.h @@ -28,6 +28,7 @@ struct genlmsghdr { #define GENL_ID_GENERATE 0 #define GENL_ID_CTRL NLMSG_MIN_TYPE #define GENL_ID_VFS_DQUOT (NLMSG_MIN_TYPE + 1) +#define GENL_ID_PMCRAID (NLMSG_MIN_TYPE + 2) /************************************************************************** * Controller |