diff options
| author | Christoph Hellwig <hch@infradead.org> | 2011-11-23 06:54:36 -0500 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-12-14 11:27:02 +0000 |
| commit | 1880807adb21d741f08b747956c90bf4a6f95fbf (patch) | |
| tree | fb3815bf85679116bb455ded1a678049950a3d9f /include/target | |
| parent | 41e16e981679124c78c30f046d4f0b71d86ff1b2 (diff) | |
| download | lwn-1880807adb21d741f08b747956c90bf4a6f95fbf.tar.gz lwn-1880807adb21d741f08b747956c90bf4a6f95fbf.zip | |
target: make the se_task task_state_active a normal bool
There is no need to make task_state_active an atomic_t given that it is
always set under the execute_task_lock so we can make it a simple bool.
Also rename it to t_state_active to be closer to the list it guards,
and make sure all checks before the list addion/removal actually happen
under execute_task_lock.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/target')
| -rw-r--r-- | include/target/target_core_base.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index e2473e6770b3..311f5fc607e6 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -491,10 +491,10 @@ struct se_task { u16 task_flags; u8 task_scsi_status; enum dma_data_direction task_data_direction; - atomic_t task_state_active; struct list_head t_list; struct list_head t_execute_list; struct list_head t_state_list; + bool t_state_active; struct completion task_stop_comp; } ____cacheline_aligned; |