diff options
| author | Moni Shoua <monis@mellanox.com> | 2014-03-27 10:52:58 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-06 07:59:28 -0700 |
| commit | 5daac1bcbb85cbf03e7e7d3cafeeb31977d82113 (patch) | |
| tree | a4da75b86f30ec480091d79796b5b5286e489702 /include/rdma | |
| parent | 9fedb513ae782fbe1e315afa269eb6a661e40942 (diff) | |
| download | lwn-5daac1bcbb85cbf03e7e7d3cafeeb31977d82113.tar.gz lwn-5daac1bcbb85cbf03e7e7d3cafeeb31977d82113.zip | |
IB/core: Don't resolve passive side RoCE L2 address in CMA REQ handler
commit b2853fd6c2d0f383dbdf7427e263eb576a633867 upstream.
The code that resolves the passive side source MAC within the rdma_cm
connection request handler was both redundant and buggy, so remove it.
It was redundant since later, when an RC QP is modified to RTR state,
the resolution will take place in the ib_core module. It was buggy
because this callback also deals with UD SIDR exchange, for which we
incorrectly looked at the REQ member of the CM event and dereferenced
a random value.
Fixes: dd5f03beb4f7 ("IB/core: Ethernet L2 attributes in verbs/cm structures")
Signed-off-by: Moni Shoua <monis@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/rdma')
| -rw-r--r-- | include/rdma/ib_cm.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/rdma/ib_cm.h b/include/rdma/ib_cm.h index f29e3a27c2cc..0e3ff30647d5 100644 --- a/include/rdma/ib_cm.h +++ b/include/rdma/ib_cm.h @@ -601,5 +601,4 @@ struct ib_cm_sidr_rep_param { int ib_send_cm_sidr_rep(struct ib_cm_id *cm_id, struct ib_cm_sidr_rep_param *param); -int ib_update_cm_av(struct ib_cm_id *id, const u8 *smac, const u8 *alt_smac); #endif /* IB_CM_H */ |