diff options
| author | Paolo Abeni <pabeni@redhat.com> | 2019-04-10 14:32:38 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-10 12:20:46 -0700 |
| commit | 1f5e6fdd6aec7929e67afad1e42e35d894a119ae (patch) | |
| tree | a473860ae14f8a116b3cf7f510c42f456c9a3cd9 /include/net/sch_generic.h | |
| parent | b0a231a26d56265521abbb6db1748accd6bb036a (diff) | |
| download | lwn-1f5e6fdd6aec7929e67afad1e42e35d894a119ae.tar.gz lwn-1f5e6fdd6aec7929e67afad1e42e35d894a119ae.zip | |
net: sched: prefer qdisc_is_empty() over direct qlen access
When checking for root qdisc queue length, do not access directly q.qlen.
In the following patches we will move back qlen accounting to per CPU
values for NOLOCK qdiscs.
Instead, prefer the qdisc_is_empty() helper usage.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/sch_generic.h')
| -rw-r--r-- | include/net/sch_generic.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index 0aea0e262452..7ecb6127e980 100644 --- a/include/net/sch_generic.h +++ b/include/net/sch_generic.h @@ -747,7 +747,7 @@ static inline bool qdisc_all_tx_empty(const struct net_device *dev) struct netdev_queue *txq = netdev_get_tx_queue(dev, i); const struct Qdisc *q = rcu_dereference(txq->qdisc); - if (q->q.qlen) { + if (!qdisc_is_empty(q)) { rcu_read_unlock(); return false; } |