diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2013-10-09 14:08:09 +0200 |
|---|---|---|
| committer | Oleg Nesterov <oleg@redhat.com> | 2013-10-29 18:02:47 +0100 |
| commit | c2d3f25dda016d9697c5416810d4528770f0a281 (patch) | |
| tree | 68dd2beb6bf33a1862096b404e091c01aaf94b18 /include/linux/uprobes.h | |
| parent | 5a3126d4fe7c311fe12f98fef0470f6cb582d1ef (diff) | |
| download | lwn-c2d3f25dda016d9697c5416810d4528770f0a281.tar.gz lwn-c2d3f25dda016d9697c5416810d4528770f0a281.zip | |
uprobes: Remove the wrong __weak attribute
linux/uprobes.h declares arch_uprobe_skip_sstep() as a weak function.
But as there is no definition of generic version so when trying to build
uprobes for an architecture that doesn't yet have a arch_uprobe_skip_sstep()
implementation, the vmlinux will try to call arch_uprobe_skip_sstep()
somehwere in Stupidhistan leading to a system crash. We rather want a
proper link error so remove arch_uprobe_skip_sstep().
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Diffstat (limited to 'include/linux/uprobes.h')
| -rw-r--r-- | include/linux/uprobes.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index 06f28beed7c2..e6fba627ea45 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h @@ -123,7 +123,7 @@ extern int uprobe_post_sstep_notifier(struct pt_regs *regs); extern int uprobe_pre_sstep_notifier(struct pt_regs *regs); extern void uprobe_notify_resume(struct pt_regs *regs); extern bool uprobe_deny_signal(void); -extern bool __weak arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); +extern bool arch_uprobe_skip_sstep(struct arch_uprobe *aup, struct pt_regs *regs); extern void uprobe_clear_state(struct mm_struct *mm); #else /* !CONFIG_UPROBES */ struct uprobes_state { |