diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2016-07-16 15:22:55 -0500 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2016-08-08 09:17:16 -0500 |
| commit | 13bcc6a2853435bb5dad368bcbaa9d2a5b9c0ac4 (patch) | |
| tree | 3c852b1ed6545b504ea23f5353d3570f46316d16 /include/linux/sysctl.h | |
| parent | 29b4817d4018df78086157ea3a55c1d9424a7cfc (diff) | |
| download | lwn-13bcc6a2853435bb5dad368bcbaa9d2a5b9c0ac4.tar.gz lwn-13bcc6a2853435bb5dad368bcbaa9d2a5b9c0ac4.zip | |
sysctl: Stop implicitly passing current into sysctl_table_root.lookup
Passing nsproxy into sysctl_table_root.lookup was a premature
optimization in attempt to avoid depending on current. The
directory /proc/self/sys has not appeared and if and when
it does this code will need to be reviewed closely and reworked
anyway. So remove the premature optimization.
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'include/linux/sysctl.h')
| -rw-r--r-- | include/linux/sysctl.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index 697e160c78d0..f166ca0203e2 100644 --- a/include/linux/sysctl.h +++ b/include/linux/sysctl.h @@ -155,8 +155,7 @@ struct ctl_table_set { struct ctl_table_root { struct ctl_table_set default_set; - struct ctl_table_set *(*lookup)(struct ctl_table_root *root, - struct nsproxy *namespaces); + struct ctl_table_set *(*lookup)(struct ctl_table_root *root); int (*permissions)(struct ctl_table_header *head, struct ctl_table *table); }; |