summaryrefslogtreecommitdiff
path: root/include/linux/seq_buf.h
diff options
context:
space:
mode:
authorErick Archer <erick.archer@gmx.com>2024-01-15 19:16:58 +0100
committerSteven Rostedt (Google) <rostedt@goodmis.org>2024-01-16 17:52:33 -0500
commit1057066009c4325bb1d8430c9274894d0860e7c3 (patch)
tree57f27c262f8104ee6ecd7fcafb3f74dfdcd84736 /include/linux/seq_buf.h
parent852e46e239ee6db3cd220614cf8bce96e79227c2 (diff)
downloadlwn-1057066009c4325bb1d8430c9274894d0860e7c3.tar.gz
lwn-1057066009c4325bb1d8430c9274894d0860e7c3.zip
eventfs: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Link: https://lore.kernel.org/linux-trace-kernel/20240115181658.4562-1-erick.archer@gmx.com Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Mark Rutland <mark.rutland@arm.com> Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Diffstat (limited to 'include/linux/seq_buf.h')
0 files changed, 0 insertions, 0 deletions