diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2023-05-11 11:52:42 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2023-05-18 11:40:32 -0700 |
| commit | fc522f3bdf43efa75b54775978b6b6c19d0d997d (patch) | |
| tree | 875d44a1d61311238cd4accf02370012be5c51e2 /include/linux/libps2.h | |
| parent | 100e16959c3ca8cb7be788ed3e2c5867481f35f6 (diff) | |
| download | lwn-fc522f3bdf43efa75b54775978b6b6c19d0d997d.tar.gz lwn-fc522f3bdf43efa75b54775978b6b6c19d0d997d.zip | |
Input: libps2 - remove special handling of ACK for command byte
When getting unexpected data while waiting for an acknowledgement it does
not matter what command phase is currently executed, and ps2_handle_ack()
should indicate that no further processing is needed for the received data
byte. Remove PS2_FLAG_ACK_CMD and associated handling.
Note that while it is possible to make ps2_handle_ack (and
ps2_handle_repsonse) return void, it will be done when the code will be
converted to common PS/2 interrupt handler later.
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
Link: https://lore.kernel.org/r/20230511185252.386941-3-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'include/linux/libps2.h')
| -rw-r--r-- | include/linux/libps2.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/libps2.h b/include/linux/libps2.h index 53f7e4d0f4b7..193dd53ad18b 100644 --- a/include/linux/libps2.h +++ b/include/linux/libps2.h @@ -28,7 +28,6 @@ #define PS2_FLAG_CMD1 BIT(2) /* Waiting for the first byte of command response */ #define PS2_FLAG_WAITID BIT(3) /* Command executing is GET ID */ #define PS2_FLAG_NAK BIT(4) /* Last transmission was NAKed */ -#define PS2_FLAG_ACK_CMD BIT(5) /* Waiting to ACK the command (first) byte */ struct ps2dev { struct serio *serio; |