diff options
author | Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> | 2008-02-07 00:15:22 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-07 08:42:25 -0800 |
commit | 1e4f2955433231b4b02dc4a9eb5d4d403a8680e1 (patch) | |
tree | 8414e9b4b5b22f201cbd993630d8ac13a98cd24c /include/linux/kexec.h | |
parent | c76f860c44357f560a763d2894e95464cab7b159 (diff) | |
download | lwn-1e4f2955433231b4b02dc4a9eb5d4d403a8680e1.tar.gz lwn-1e4f2955433231b4b02dc4a9eb5d4d403a8680e1.zip |
vmcoreinfo: use the existing offsetof() for VMCOREINFO_OFFSET()
It is better that the existing offsetof() is used for VMCOREINFO_OFFSET().
This discussion is the following:
http://www.ussg.iu.edu/hypermail/linux/kernel/0709.3/0584.html
Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Acked-by: Simon Horman <horms@verge.net.au>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/kexec.h')
-rw-r--r-- | include/linux/kexec.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 39112a0e4693..cbc3cd7e11c1 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -137,7 +137,7 @@ unsigned long paddr_vmcoreinfo_note(void); (unsigned long)sizeof(struct name)) #define VMCOREINFO_OFFSET(name, field) \ vmcoreinfo_append_str("OFFSET(%s.%s)=%lu\n", #name, #field, \ - (unsigned long)&(((struct name *)0)->field)) + (unsigned long)offsetof(struct name, field)) #define VMCOREINFO_LENGTH(name, value) \ vmcoreinfo_append_str("LENGTH(%s)=%lu\n", #name, (unsigned long)value) #define VMCOREINFO_NUMBER(name) \ |