diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-11-17 23:56:09 -0800 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2020-11-24 15:10:27 -0800 |
| commit | 234f1b7f8daf112655c87f75ae8932564f871225 (patch) | |
| tree | 50d6a76def3f3056ab97aa37208b0a95426897e9 /include/linux/fscrypt.h | |
| parent | 76786a0f083473de31678bdb259a3d4167cf756d (diff) | |
| download | lwn-234f1b7f8daf112655c87f75ae8932564f871225.tar.gz lwn-234f1b7f8daf112655c87f75ae8932564f871225.zip | |
fscrypt: remove unnecessary calls to fscrypt_require_key()
In an encrypted directory, a regular dentry (one that doesn't have the
no-key name flag) can only be created if the directory's encryption key
is available.
Therefore the calls to fscrypt_require_key() in __fscrypt_prepare_link()
and __fscrypt_prepare_rename() are unnecessary, as these functions
already check that the dentries they're given aren't no-key names.
Remove these unnecessary calls to fscrypt_require_key().
Link: https://lore.kernel.org/r/20201118075609.120337-6-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'include/linux/fscrypt.h')
| -rw-r--r-- | include/linux/fscrypt.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h index 8e1d31c959bf..0c9e64969b73 100644 --- a/include/linux/fscrypt.h +++ b/include/linux/fscrypt.h @@ -710,8 +710,7 @@ static inline int fscrypt_require_key(struct inode *inode) * * A new link can only be added to an encrypted directory if the directory's * encryption key is available --- since otherwise we'd have no way to encrypt - * the filename. Therefore, we first set up the directory's encryption key (if - * not already done) and return an error if it's unavailable. + * the filename. * * We also verify that the link will not violate the constraint that all files * in an encrypted directory tree use the same encryption policy. |