summaryrefslogtreecommitdiff
path: root/include/linux/fs.h
diff options
context:
space:
mode:
authorJonathan Corbet <corbet@lwn.net>2009-03-27 12:24:31 -0600
committerJonathan Corbet <corbet@lwn.net>2009-03-30 08:00:24 -0600
commit4a6a4499693a419a20559c41e33a7bd70bf20a6f (patch)
tree7a89d08f0b2f19e1b84b38869596c8a84ab6f583 /include/linux/fs.h
parent996ff68d8b358885c1de82a45517c607999947c7 (diff)
downloadlwn-4a6a4499693a419a20559c41e33a7bd70bf20a6f.tar.gz
lwn-4a6a4499693a419a20559c41e33a7bd70bf20a6f.zip
Fix a lockdep warning in fasync_helper()
Lockdep gripes if file->f_lock is taken in a no-IRQ situation, since that is not always the case. We don't really want to disable IRQs for every acquisition of f_lock; instead, just move it outside of fasync_lock. Reported-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Reported-by: Wu Fengguang <fengguang.wu@intel.com> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'include/linux/fs.h')
-rw-r--r--include/linux/fs.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7428c6d35e65..2f13c1d77812 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -848,7 +848,7 @@ struct file {
#define f_dentry f_path.dentry
#define f_vfsmnt f_path.mnt
const struct file_operations *f_op;
- spinlock_t f_lock; /* f_ep_links, f_flags */
+ spinlock_t f_lock; /* f_ep_links, f_flags, no IRQ */
atomic_long_t f_count;
unsigned int f_flags;
fmode_t f_mode;