diff options
author | Andre Müller <andre.muller@web.de> | 2014-09-10 01:00:22 +0200 |
---|---|---|
committer | Matt Fleming <matt.fleming@intel.com> | 2014-10-03 18:41:03 +0100 |
commit | 77e21e87acec8c857df4bfbc647ea21d0a87364d (patch) | |
tree | 46ab040024983bb6ba250e6096fd1c7db3d483d4 /include/linux/efi.h | |
parent | 4e78eb056136b002ecdfbbf61436fedfb8a3c76b (diff) | |
download | lwn-77e21e87acec8c857df4bfbc647ea21d0a87364d.tar.gz lwn-77e21e87acec8c857df4bfbc647ea21d0a87364d.zip |
x86/efi: Adding efi_printks on memory allocationa and pci.reads
All other calls to allocate memory seem to make some noise already, with the
exception of two calls (for gop, uga) in the setup_graphics path.
The purpose is to be noisy on worrysome errors immediately.
commit fb86b2440de0 ("x86/efi: Add better error logging to EFI boot
stub") introduces printing false alarms for lots of hardware. Rather
than playing Whack a Mole with non-fatal exit conditions, try the other
way round.
This is per Matt Fleming's suggestion:
> Where I think we could improve things
> is by adding efi_printk() message in certain error paths. Clearly, not
> all error paths need such messages, e.g. the EFI_INVALID_PARAMETER path
> you highlighted above, but it makes sense for memory allocation and PCI
> read failures.
Link: http://article.gmane.org/gmane.linux.kernel.efi/4628
Signed-off-by: Andre Müller <andre.muller@web.de>
Cc: Ulf Winkelvos <ulf@winkelvos.de>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'include/linux/efi.h')
0 files changed, 0 insertions, 0 deletions