diff options
| author | NeilBrown <neil@brown.name> | 2019-01-06 21:06:25 +1100 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2019-03-05 14:48:52 -0500 |
| commit | 0bdb50c531f7377a9da80d3ce2d61f389c84cb30 (patch) | |
| tree | 73c7dc72106541c696fa61e40c2484eddd443987 /include/linux/device-mapper.h | |
| parent | d2832376b69e1e02cae0de660ab7c03223f09341 (diff) | |
| download | lwn-0bdb50c531f7377a9da80d3ce2d61f389c84cb30.tar.gz lwn-0bdb50c531f7377a9da80d3ce2d61f389c84cb30.zip | |
dm: fix to_sector() for 32bit
A dm-raid array with devices larger than 4GB won't assemble on
a 32 bit host since _check_data_dev_sectors() was added in 4.16.
This is because to_sector() treats its argument as an "unsigned long"
which is 32bits (4GB) on a 32bit host. Using "unsigned long long"
is more correct.
Kernels as early as 4.2 can have other problems due to to_sector()
being used on the size of a device.
Fixes: 0cf4503174c1 ("dm raid: add support for the MD RAID0 personality")
cc: stable@vger.kernel.org (v4.2+)
Reported-and-tested-by: Guillaume Perréal <gperreal@free.fr>
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'include/linux/device-mapper.h')
| -rw-r--r-- | include/linux/device-mapper.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h index 0f5b3d7c6cb3..52e8709c6df0 100644 --- a/include/linux/device-mapper.h +++ b/include/linux/device-mapper.h @@ -603,7 +603,7 @@ do { \ */ #define dm_target_offset(ti, sector) ((sector) - (ti)->begin) -static inline sector_t to_sector(unsigned long n) +static inline sector_t to_sector(unsigned long long n) { return (n >> SECTOR_SHIFT); } |