diff options
| author | Ingo Molnar <mingo@elte.hu> | 2006-12-22 01:08:52 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-22 08:55:48 -0800 |
| commit | 9127d4b1d9b2e8fba8e7fbc7f88ea93e5eb01396 (patch) | |
| tree | 72ca7baa89ae9d7f55747b28aff8e7eda5b54eee /include/linux/debug_locks.h | |
| parent | ba3ff12fca318225cb978c6181b83d38dcbc5b09 (diff) | |
| download | lwn-9127d4b1d9b2e8fba8e7fbc7f88ea93e5eb01396.tar.gz lwn-9127d4b1d9b2e8fba8e7fbc7f88ea93e5eb01396.zip | |
[PATCH] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent
Matthew Wilcox noticed that the debug_locks_silent use should be inverted
in DEBUG_LOCKS_WARN_ON(). This bug was causing spurious stacktraces and
incorrect failures in the locking self-test on the parisc kernel.
Bug-found-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/debug_locks.h')
| -rw-r--r-- | include/linux/debug_locks.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h index a1c10b0c4cf0..1678a5de7013 100644 --- a/include/linux/debug_locks.h +++ b/include/linux/debug_locks.h @@ -24,7 +24,7 @@ extern int debug_locks_off(void); int __ret = 0; \ \ if (unlikely(c)) { \ - if (debug_locks_silent || debug_locks_off()) \ + if (debug_locks_off() && !debug_locks_silent) \ WARN_ON(1); \ __ret = 1; \ } \ |