diff options
| author | Lorenz Bauer <lmb@cloudflare.com> | 2021-04-29 14:46:56 +0100 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2021-05-10 16:13:01 -0700 |
| commit | c9e73e3d2b1eb1ea7ff068e05007eec3bd8ef1c9 (patch) | |
| tree | 4a7faeae5e95b86efce632ff25f08a15b725dea9 /include/linux/bpf_verifier.h | |
| parent | 06ab6a505583f9adbf5e1f05d86e7bdd7b02248e (diff) | |
| download | lwn-c9e73e3d2b1eb1ea7ff068e05007eec3bd8ef1c9.tar.gz lwn-c9e73e3d2b1eb1ea7ff068e05007eec3bd8ef1c9.zip | |
bpf: verifier: Allocate idmap scratch in verifier env
func_states_equal makes a very short lived allocation for idmap,
probably because it's too large to fit on the stack. However the
function is called quite often, leading to a lot of alloc / free
churn. Replace the temporary allocation with dedicated scratch
space in struct bpf_verifier_env.
Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/bpf/20210429134656.122225-4-lmb@cloudflare.com
Diffstat (limited to 'include/linux/bpf_verifier.h')
| -rw-r--r-- | include/linux/bpf_verifier.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/include/linux/bpf_verifier.h b/include/linux/bpf_verifier.h index 06841517ab1e..d4632aa3ca50 100644 --- a/include/linux/bpf_verifier.h +++ b/include/linux/bpf_verifier.h @@ -215,6 +215,13 @@ struct bpf_idx_pair { u32 idx; }; +struct bpf_id_pair { + u32 old; + u32 cur; +}; + +/* Maximum number of register states that can exist at once */ +#define BPF_ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE) #define MAX_CALL_FRAMES 8 struct bpf_verifier_state { /* call stack tracking */ @@ -418,6 +425,7 @@ struct bpf_verifier_env { const struct bpf_line_info *prev_linfo; struct bpf_verifier_log log; struct bpf_subprog_info subprog_info[BPF_MAX_SUBPROGS + 1]; + struct bpf_id_pair idmap_scratch[BPF_ID_MAP_SIZE]; struct { int *insn_state; int *insn_stack; |