diff options
| author | Jens Axboe <axboe@fb.com> | 2015-04-09 15:54:05 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-04-09 15:54:05 -0600 |
| commit | 2963e3f7e8e3465895897a175560210120b932ac (patch) | |
| tree | 7c27aa09aa01cbdef12016b48728f3e9383d3b4d /include/linux/blk-mq.h | |
| parent | c76cbbcf404475f8885b2252049dac99b0614868 (diff) | |
| download | lwn-2963e3f7e8e3465895897a175560210120b932ac.tar.gz lwn-2963e3f7e8e3465895897a175560210120b932ac.zip | |
blk-mq: cleanup blk_mq_rq_to_pdu()
Casting to void and adding the size of the request is "shit code" and
only a "crazy monkey on crack" would write that. So lets clean it up.
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'include/linux/blk-mq.h')
| -rw-r--r-- | include/linux/blk-mq.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index ebfe707cf722..8210e8797c12 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -230,7 +230,7 @@ void blk_mq_freeze_queue_start(struct request_queue *q); /* * Driver command data is immediately after the request. So subtract request - * size to get back to the original request. + * size to get back to the original request, add request size to get the PDU. */ static inline struct request *blk_mq_rq_from_pdu(void *pdu) { @@ -238,7 +238,7 @@ static inline struct request *blk_mq_rq_from_pdu(void *pdu) } static inline void *blk_mq_rq_to_pdu(struct request *rq) { - return (void *) rq + sizeof(*rq); + return rq + 1; } #define queue_for_each_hw_ctx(q, hctx, i) \ |