diff options
author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-04-14 17:45:31 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:00 -0400 |
commit | 5e427571c59c26b04f483b305cf0e63498f21601 (patch) | |
tree | 9ad30d4738c8ae91cae72446fa3adb911ee9e819 /fs | |
parent | a0c9cc1727ecf302ab0be07e93d0c023e64be8da (diff) | |
download | lwn-5e427571c59c26b04f483b305cf0e63498f21601.tar.gz lwn-5e427571c59c26b04f483b305cf0e63498f21601.zip |
bcachefs: Don't call bch2_btree_iter_traverse() unnecessarily
If we let bch2_trans_commit() do it, it'll traverse iterators in sorted
order which means we'll get fewer lock restarts.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/bcachefs/btree_update_leaf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c index c5dab99b0cfc..9a747b420180 100644 --- a/fs/bcachefs/btree_update_leaf.c +++ b/fs/bcachefs/btree_update_leaf.c @@ -1153,8 +1153,7 @@ int __bch2_btree_insert(struct btree_trans *trans, iter = bch2_trans_get_iter(trans, id, bkey_start_pos(&k->k), BTREE_ITER_INTENT); - ret = bch2_btree_iter_traverse(iter) ?: - bch2_trans_update(trans, iter, k, 0); + ret = bch2_trans_update(trans, iter, k, 0); bch2_trans_iter_put(trans, iter); return ret; } |