summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorKemeng Shi <shikemeng@huaweicloud.com>2024-01-05 17:21:02 +0800
committerTheodore Ts'o <tytso@mit.edu>2024-01-18 10:52:45 -0500
commitf0e54b6087de9571ec61c189d6c378b81edbe3b2 (patch)
tree0967245d3609540e3a52e464f70d8280620e40c9 /fs
parent2ffd2a6ad1d3a8213bb5805f45f49098fe615db1 (diff)
downloadlwn-f0e54b6087de9571ec61c189d6c378b81edbe3b2.tar.gz
lwn-f0e54b6087de9571ec61c189d6c378b81edbe3b2.zip
ext4: remove 'needed' in trace_ext4_discard_preallocations
As 'needed' to trace_ext4_discard_preallocations is always 0 which is meaningless. Just remove it. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Suggested-by: Jan Kara <jack@suse.cz> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240105092102.496631-10-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/mballoc.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index f3da7db2beee..e4f7cf9d89c4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -5510,9 +5510,8 @@ void ext4_discard_preallocations(struct inode *inode)
struct rb_node *iter;
int err;
- if (!S_ISREG(inode->i_mode)) {
+ if (!S_ISREG(inode->i_mode))
return;
- }
if (EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY)
return;
@@ -5520,7 +5519,7 @@ void ext4_discard_preallocations(struct inode *inode)
mb_debug(sb, "discard preallocation for inode %lu\n",
inode->i_ino);
trace_ext4_discard_preallocations(inode,
- atomic_read(&ei->i_prealloc_active), 0);
+ atomic_read(&ei->i_prealloc_active));
repeat:
/* first, collect all pa's in the inode */