diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2023-10-02 03:36:43 +0100 |
|---|---|---|
| committer | Amir Goldstein <amir73il@gmail.com> | 2023-10-02 17:44:19 +0300 |
| commit | c54719c92aa3129f330cce81b88cf34f1627f756 (patch) | |
| tree | b0d3dfd0806d62ac922f128fd18a5c9b37ebce3e /fs | |
| parent | d9e8319a6e3538b430f692b5625a76ffa0758adc (diff) | |
| download | lwn-c54719c92aa3129f330cce81b88cf34f1627f756.tar.gz lwn-c54719c92aa3129f330cce81b88cf34f1627f756.zip | |
ovl: fetch inode once in ovl_dentry_revalidate_common()
d_inode_rcu() is right - we might be in rcu pathwalk;
however, OVL_E() hides plain d_inode() on the same dentry...
Fixes: a6ff2bc0be17 ("ovl: use OVL_E() and OVL_E_FLAGS() accessors")
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/overlayfs/super.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c index f09184b865ec..905d3aaf4e55 100644 --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -104,8 +104,8 @@ static int ovl_revalidate_real(struct dentry *d, unsigned int flags, bool weak) static int ovl_dentry_revalidate_common(struct dentry *dentry, unsigned int flags, bool weak) { - struct ovl_entry *oe = OVL_E(dentry); - struct ovl_path *lowerstack = ovl_lowerstack(oe); + struct ovl_entry *oe; + struct ovl_path *lowerstack; struct inode *inode = d_inode_rcu(dentry); struct dentry *upper; unsigned int i; @@ -115,6 +115,8 @@ static int ovl_dentry_revalidate_common(struct dentry *dentry, if (!inode) return -ECHILD; + oe = OVL_I_E(inode); + lowerstack = ovl_lowerstack(oe); upper = ovl_i_dentry_upper(inode); if (upper) ret = ovl_revalidate_real(upper, flags, weak); |