diff options
| author | Boris Burkov <boris@bur.io> | 2023-12-01 13:00:12 -0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-12-06 22:32:52 +0100 |
| commit | a86805504b88f636a6458520d85afdf0634e3c6b (patch) | |
| tree | 2dff8f9bbc89708cef9379c493f35bf92bb6ccd2 /fs | |
| parent | b321a52cce062ec7ed385333a33905d22159ce36 (diff) | |
| download | lwn-a86805504b88f636a6458520d85afdf0634e3c6b.tar.gz lwn-a86805504b88f636a6458520d85afdf0634e3c6b.zip | |
btrfs: don't clear qgroup reserved bit in release_folio
The EXTENT_QGROUP_RESERVED bit is used to "lock" regions of the file for
duplicate reservations. That is two writes to that range in one
transaction shouldn't create two reservations, as the reservation will
only be freed once when the write finally goes down. Therefore, it is
never OK to clear that bit without freeing the associated qgroup
reserve. At this point, we don't want to be freeing the reserve, so mask
off the bit.
CC: stable@vger.kernel.org # 5.15+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/extent_io.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index e6230a6ffa98..8f724c54fc8e 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2302,7 +2302,8 @@ static int try_release_extent_state(struct extent_io_tree *tree, ret = 0; } else { u32 clear_bits = ~(EXTENT_LOCKED | EXTENT_NODATASUM | - EXTENT_DELALLOC_NEW | EXTENT_CTLBITS); + EXTENT_DELALLOC_NEW | EXTENT_CTLBITS | + EXTENT_QGROUP_RESERVED); /* * At this point we can safely clear everything except the |