diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2023-12-04 22:20:46 +0900 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-12-08 10:11:33 -0600 |
| commit | 658609d9a618d8881bf549b5893c0ba8fcff4526 (patch) | |
| tree | e99f66c7b2f5918e4b2926747d84e42d69f5098b /fs | |
| parent | c2a721eead71202a0d8ddd9b56ec8dce652c71d1 (diff) | |
| download | lwn-658609d9a618d8881bf549b5893c0ba8fcff4526.tar.gz lwn-658609d9a618d8881bf549b5893c0ba8fcff4526.zip | |
ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack()
opinfo_put() could be called twice on error of smb21_lease_break_ack().
It will cause UAF issue if opinfo is referenced on other places.
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/smb2pdu.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 45fc4bc3ac19..f3af83dc49c4 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8219,6 +8219,11 @@ static void smb21_lease_break_ack(struct ksmbd_work *work) le32_to_cpu(req->LeaseState)); } + if (ret < 0) { + rsp->hdr.Status = err; + goto err_out; + } + lease_state = lease->state; opinfo->op_state = OPLOCK_STATE_NONE; wake_up_interruptible_all(&opinfo->oplock_q); @@ -8226,11 +8231,6 @@ static void smb21_lease_break_ack(struct ksmbd_work *work) wake_up_interruptible_all(&opinfo->oplock_brk); opinfo_put(opinfo); - if (ret < 0) { - rsp->hdr.Status = err; - goto err_out; - } - rsp->StructureSize = cpu_to_le16(36); rsp->Reserved = 0; rsp->Flags = 0; |