diff options
author | J. Bruce Fields <bfields@redhat.com> | 2015-04-21 15:25:39 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2015-04-21 16:16:01 -0400 |
commit | 980608fb50aea34993ba956b71cd4602aa42b14b (patch) | |
tree | a6105aecef17dd3bc25bb1754acb87bbf0639255 /fs | |
parent | 5ba4a25ab7b13be528b23f85182f4d09cf7f71ad (diff) | |
download | lwn-980608fb50aea34993ba956b71cd4602aa42b14b.tar.gz lwn-980608fb50aea34993ba956b71cd4602aa42b14b.zip |
nfsd4: disallow SEEK with special stateids
If the client uses a special stateid then we'll pass a NULL file to
vfs_llseek.
Fixes: 24bab491220f " NFSD: Implement SEEK"
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: stable@vger.kernel.org
Reported-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/nfsd/nfs4proc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index d0848fc6529e..4a8314f08a0e 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -1071,6 +1071,8 @@ nfsd4_seek(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, dprintk("NFSD: nfsd4_seek: couldn't process stateid!\n"); return status; } + if (!file) + return nfserr_bad_stateid; switch (seek->seek_whence) { case NFS4_CONTENT_DATA: |