diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2014-07-25 15:47:23 -0700 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2014-07-30 14:13:35 -0700 |
| commit | 61e0f2d0a5f2cddf7cd96fa8cb7fe53a1e5e325d (patch) | |
| tree | 3c1cc4497995df3c37b979b3b46c9b589db75b4d /fs | |
| parent | 01229f5e1b21b378863c91f8c653bbd8e593858c (diff) | |
| download | lwn-61e0f2d0a5f2cddf7cd96fa8cb7fe53a1e5e325d.tar.gz lwn-61e0f2d0a5f2cddf7cd96fa8cb7fe53a1e5e325d.zip | |
f2fs: test before set/clear bits
If the bit is already set, we don't need to reset it, and vice versa.
Because we don't need to make the caches dirty for that.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/f2fs.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 8f8685e16863..475f97ca49ae 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1003,7 +1003,8 @@ enum { static inline void set_inode_flag(struct f2fs_inode_info *fi, int flag) { - set_bit(flag, &fi->flags); + if (!test_bit(flag, &fi->flags)) + set_bit(flag, &fi->flags); } static inline int is_inode_flag_set(struct f2fs_inode_info *fi, int flag) @@ -1013,7 +1014,8 @@ static inline int is_inode_flag_set(struct f2fs_inode_info *fi, int flag) static inline void clear_inode_flag(struct f2fs_inode_info *fi, int flag) { - clear_bit(flag, &fi->flags); + if (test_bit(flag, &fi->flags)) + clear_bit(flag, &fi->flags); } static inline void set_acl_inode(struct f2fs_inode_info *fi, umode_t mode) |