diff options
| author | Nikolay Borisov <kernel@kyup.com> | 2016-03-03 10:54:57 +0100 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-04-18 08:50:45 -0400 |
| commit | ab1cc52b3f62f2445c60cbe390d26c50ebc0f3bd (patch) | |
| tree | bb8f4a16b7f4c014071073399c107b06bf9ab023 /fs | |
| parent | 594103da3005639712b3123a612791c8f4d3f4e9 (diff) | |
| download | lwn-ab1cc52b3f62f2445c60cbe390d26c50ebc0f3bd.tar.gz lwn-ab1cc52b3f62f2445c60cbe390d26c50ebc0f3bd.zip | |
quota: Fix possible GPF due to uninitialised pointers
[ Upstream commit ab73ef46398e2c0159f3a71de834586422d2a44a ]
When dqget() in __dquot_initialize() fails e.g. due to IO error,
__dquot_initialize() will pass an array of uninitialized pointers to
dqput_all() and thus can lead to deference of random data. Fix the
problem by properly initializing the array.
CC: stable@vger.kernel.org
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/quota/dquot.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 20d1f74561cf..19c777ad0084 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -1393,7 +1393,7 @@ static int dquot_active(const struct inode *inode) static void __dquot_initialize(struct inode *inode, int type) { int cnt, init_needed = 0; - struct dquot **dquots, *got[MAXQUOTAS]; + struct dquot **dquots, *got[MAXQUOTAS] = {}; struct super_block *sb = inode->i_sb; qsize_t rsv; @@ -1408,7 +1408,6 @@ static void __dquot_initialize(struct inode *inode, int type) kprojid_t projid; int rc; - got[cnt] = NULL; if (type != -1 && cnt != type) continue; /* |