diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2016-01-14 13:41:14 +0300 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-02-03 16:23:16 -0500 |
| commit | c5882812d2e1ab7db5bc71a1bca90b3a2d89dedd (patch) | |
| tree | 996a4e80899dedd66197aff35e2a6d6add7966f4 /fs | |
| parent | 99b79b15df4ed1a6293cff487b46efc86bd20ae5 (diff) | |
| download | lwn-c5882812d2e1ab7db5bc71a1bca90b3a2d89dedd.tar.gz lwn-c5882812d2e1ab7db5bc71a1bca90b3a2d89dedd.zip | |
cifs_dbg() outputs an uninitialized buffer in cifs_readdir()
[ Upstream commit 01b9b0b28626db4a47d7f48744d70abca9914ef1 ]
In some cases tmp_bug can be not filled in cifs_filldir and stay uninitialized,
therefore its printk with "%s" modifier can leak content of kernelspace memory.
If old content of this buffer does not contain '\0' access bejond end of
allocated object can crash the host.
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Steve French <sfrench@localhost.localdomain>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/readdir.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index b1eede3678a9..3634c7adf7d2 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c @@ -847,6 +847,7 @@ int cifs_readdir(struct file *file, struct dir_context *ctx) * if buggy server returns . and .. late do we want to * check for that here? */ + *tmp_buf = 0; rc = cifs_filldir(current_entry, file, ctx, tmp_buf, max_len); if (rc) { |