diff options
| author | Liu Bo <bo.li.liu@oracle.com> | 2014-07-24 22:48:05 +0800 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-08-15 07:43:18 -0700 |
| commit | ce62003f690dff38d3164a632ec69efa15c32cbf (patch) | |
| tree | 5cf6ced20c580a18e50496ca926bbb256ddb5bc7 /fs | |
| parent | f90e579c2b391979630b3343de0be65ab1b478ce (diff) | |
| download | lwn-ce62003f690dff38d3164a632ec69efa15c32cbf.tar.gz lwn-ce62003f690dff38d3164a632ec69efa15c32cbf.zip | |
Btrfs: fix compressed write corruption on enospc
When failing to allocate space for the whole compressed extent, we'll
fallback to uncompressed IO, but we've forgotten to redirty the pages
which belong to this compressed extent, and these 'clean' pages will
simply skip 'submit' part and go to endio directly, at last we got data
corruption as we write nothing.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Tested-By: Martin Steigerwald <martin@lichtvoll.de>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/inode.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 3668048e16f8..8ea7610fbaf3 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -709,6 +709,18 @@ retry: unlock_extent(io_tree, async_extent->start, async_extent->start + async_extent->ram_size - 1); + + /* + * we need to redirty the pages if we decide to + * fallback to uncompressed IO, otherwise we + * will not submit these pages down to lower + * layers. + */ + extent_range_redirty_for_io(inode, + async_extent->start, + async_extent->start + + async_extent->ram_size - 1); + goto retry; } goto out_free; |