diff options
| author | NeilBrown <neilb@suse.de> | 2012-11-08 16:09:37 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-11 09:18:39 -0800 |
| commit | dfde3c6d130f2e679024bd7b8692a4d00bac4ef8 (patch) | |
| tree | 9d02be1b5bacaee1324055380cb520cabe205b18 /fs | |
| parent | 2fc2d6907a79876e6c9dc3d3cd4565b319756750 (diff) | |
| download | lwn-dfde3c6d130f2e679024bd7b8692a4d00bac4ef8.tar.gz lwn-dfde3c6d130f2e679024bd7b8692a4d00bac4ef8.zip | |
vfs: d_obtain_alias() needs to use "/" as default name.
commit b911a6bdeef5848c468597d040e3407e0aee04ce upstream.
NFS appears to use d_obtain_alias() to create the root dentry rather than
d_make_root. This can cause 'prepend_path()' to complain that the root
has a weird name if an NFS filesystem is lazily unmounted. e.g. if
"/mnt" is an NFS mount then
{ cd /mnt; umount -l /mnt ; ls -l /proc/self/cwd; }
will cause a WARN message like
WARNING: at /home/git/linux/fs/dcache.c:2624 prepend_path+0x1d7/0x1e0()
...
Root dentry has weird name <>
to appear in kernel logs.
So change d_obtain_alias() to use "/" rather than "" as the anonymous
name.
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/dcache.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dcache.c b/fs/dcache.c index 3a463d0c4fe8..0d0adb661783 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1583,7 +1583,7 @@ EXPORT_SYMBOL(d_find_any_alias); */ struct dentry *d_obtain_alias(struct inode *inode) { - static const struct qstr anonstring = { .name = "" }; + static const struct qstr anonstring = QSTR_INIT("/", 1); struct dentry *tmp; struct dentry *res; |