diff options
author | Alex Elder <elder@inktank.com> | 2012-12-07 09:57:58 -0600 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-17 08:46:48 -0800 |
commit | b624d7561efd53d4854960c82e71acb5fb4dd24b (patch) | |
tree | 367ef2bf1901f69198dfa97fd44f5c57f9b4b9ce /fs | |
parent | 1c76436d1b962c8d53871d9d13c6a01094d15b95 (diff) | |
download | lwn-b624d7561efd53d4854960c82e71acb5fb4dd24b.tar.gz lwn-b624d7561efd53d4854960c82e71acb5fb4dd24b.zip |
libceph: avoid using freed osd in __kick_osd_requests()
(cherry picked from commit 685a7555ca69030739ddb57a47f0ea8ea80196a4)
If an osd has no requests and no linger requests, __reset_osd()
will just remove it with a call to __remove_osd(). That drops
a reference to the osd, and therefore the osd may have been free
by the time __reset_osd() returns. That function offers no
indication this may have occurred, and as a result the osd will
continue to be used even when it's no longer valid.
Change__reset_osd() so it returns an error (ENODEV) when it
deletes the osd being reset. And change __kick_osd_requests() so it
returns immediately (before referencing osd again) if __reset_osd()
returns *any* error.
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions