diff options
| author | Alexey Kuznetsov <kuznet@parallels.com> | 2016-07-19 12:48:01 -0700 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2016-08-22 12:23:22 -0400 |
| commit | 689c2a8941d452a3054868afa03497b64853e29b (patch) | |
| tree | 977b6abce8a69f0f13a26614e34452f99a39f17e /fs | |
| parent | 77c6ffdbce68688492a31702f67c7dbc4eeedd62 (diff) | |
| download | lwn-689c2a8941d452a3054868afa03497b64853e29b.tar.gz lwn-689c2a8941d452a3054868afa03497b64853e29b.zip | |
fuse: fsync() did not return IO errors
[ Upstream commit ac7f052b9e1534c8248f814b6f0068ad8d4a06d2 ]
Due to implementation of fuse writeback filemap_write_and_wait_range() does
not catch errors. We have to do this directly after fuse_sync_writes()
Signed-off-by: Alexey Kuznetsov <kuznet@virtuozzo.com>
Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4d99ff8f12eb ("fuse: Turn writeback cache on")
Cc: <stable@vger.kernel.org> # v3.15+
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/fuse/file.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index e2a2c14a90ee..afdff12c0949 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -499,6 +499,21 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end, goto out; fuse_sync_writes(inode); + + /* + * Due to implementation of fuse writeback + * filemap_write_and_wait_range() does not catch errors. + * We have to do this directly after fuse_sync_writes() + */ + if (test_bit(AS_ENOSPC, &file->f_mapping->flags) && + test_and_clear_bit(AS_ENOSPC, &file->f_mapping->flags)) + err = -ENOSPC; + if (test_bit(AS_EIO, &file->f_mapping->flags) && + test_and_clear_bit(AS_EIO, &file->f_mapping->flags)) + err = -EIO; + if (err) + goto out; + err = sync_inode_metadata(inode, 1); if (err) goto out; |