diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-02-05 10:37:33 +0300 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2015-11-15 12:51:53 -0500 |
commit | 0812542d8e5337822045c81695caff87ea4f5105 (patch) | |
tree | f3def7cf542608ef3685afff7e67ab4bacb655a1 /fs | |
parent | 52e980501b7245b1e051a77342c1d5e14204b90d (diff) | |
download | lwn-0812542d8e5337822045c81695caff87ea4f5105.tar.gz lwn-0812542d8e5337822045c81695caff87ea4f5105.zip |
vhost/scsi: potential memory corruption
[ Upstream commit 59c816c1f24df0204e01851431d3bab3eb76719c ]
This code in vhost_scsi_make_tpg() is confusing because we limit "tpgt"
to UINT_MAX but the data type of "tpg->tport_tpgt" and that is a u16.
I looked at the context and it turns out that in
vhost_scsi_set_endpoint(), "tpg->tport_tpgt" is used as an offset into
the vs_tpg[] array which has VHOST_SCSI_MAX_TARGET (256) elements so
anything higher than 255 then it is invalid. I have made that the limit
now.
In vhost_scsi_send_evt() we mask away values higher than 255, but now
that the limit has changed, we don't need the mask.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions