diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-02-27 19:17:33 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:06:53 -0800 |
| commit | 478ee5e09bbd59e219cc6d281c84e9495f006ab8 (patch) | |
| tree | df2a29562aa39a98cde6b969ba0a9a81069c38b2 /fs | |
| parent | cda49c04f6cdccca0f2db13f740e707d592ef114 (diff) | |
| download | lwn-478ee5e09bbd59e219cc6d281c84e9495f006ab8.tar.gz lwn-478ee5e09bbd59e219cc6d281c84e9495f006ab8.zip | |
do_last(): don't let a bogus return value from ->open() et.al. to confuse us
commit c80567c82ae4814a41287618e315a60ecf513be6 upstream.
... into returning a positive to path_openat(), which would interpret that
as "symlink had been encountered" and proceed to corrupt memory, etc.
It can only happen due to a bug in some ->open() instance or in some LSM
hook, etc., so we report any such event *and* make sure it doesn't trick
us into further unpleasantness.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/namei.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/namei.c b/fs/namei.c index f4f6460b6958..c24781f07cf3 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3085,6 +3085,10 @@ opened: goto exit_fput; } out: + if (unlikely(error > 0)) { + WARN_ON(1); + error = -EINVAL; + } if (got_write) mnt_drop_write(nd->path.mnt); path_put(&save_parent); |