diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2014-07-27 13:00:41 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-14 08:59:46 -0800 |
| commit | 9c5f9dcad8be822dd4ebe7f9640b0c8af2c57122 (patch) | |
| tree | fd4c1b64b706b7410f61cb1fd2c82c3f4f8f6b55 /fs | |
| parent | d2d9b7b9b866f0a4a349e4ce4c2904da86df25fd (diff) | |
| download | lwn-9c5f9dcad8be822dd4ebe7f9640b0c8af2c57122.tar.gz lwn-9c5f9dcad8be822dd4ebe7f9640b0c8af2c57122.zip | |
fs: make cont_expand_zero interruptible
commit c2ca0fcd202863b14bd041a7fece2e789926c225 upstream.
This patch makes it possible to kill a process looping in
cont_expand_zero. A process may spend a lot of time in this function, so
it is desirable to be able to kill it.
It happened to me that I wanted to copy a piece data from the disk to a
file. By mistake, I used the "seek" parameter to dd instead of "skip". Due
to the "seek" parameter, dd attempted to extend the file and became stuck
doing so - the only possibility was to reset the machine or wait many
hours until the filesystem runs out of space and cont_expand_zero fails.
We need this patch to be able to terminate the process.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/buffer.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 71e2d0ed8530..2e0a9e12089b 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2313,6 +2313,11 @@ static int cont_expand_zero(struct file *file, struct address_space *mapping, err = 0; balance_dirty_pages_ratelimited(mapping); + + if (unlikely(fatal_signal_pending(current))) { + err = -EINTR; + goto out; + } } /* page covers the boundary, find the boundary offset */ |