diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2015-11-20 18:26:07 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-02-17 12:34:34 -0800 |
| commit | 4f02ad9678e2f767157c1e2a59bd54df9ab9ddf9 (patch) | |
| tree | 1e46a397fc54309d1eedce1da8dccc65e1cb35ae /fs | |
| parent | e8c26ae78168fb49905025c643a68504f060b0e7 (diff) | |
| download | lwn-4f02ad9678e2f767157c1e2a59bd54df9ab9ddf9.tar.gz lwn-4f02ad9678e2f767157c1e2a59bd54df9ab9ddf9.zip | |
remoteproc: avoid stack overflow in debugfs file
commit 92792e48e2ae6051af30468a87994b5432da2f06 upstream.
Recent gcc versions warn about reading from a negative offset of
an on-stack array:
drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]
I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions