diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2015-06-21 21:10:51 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-08-04 16:52:02 +0200 |
| commit | 592eb13673e8b083fbf72b54f410c711f950fb71 (patch) | |
| tree | 9329c393954611fe7d76ec393fb9170078c0a42a /fs | |
| parent | 18cb11c2ca2e4e786aa1b1f58c978aa33885944a (diff) | |
| download | lwn-592eb13673e8b083fbf72b54f410c711f950fb71.tar.gz lwn-592eb13673e8b083fbf72b54f410c711f950fb71.zip | |
ext4: don't retry file block mapping on bigalloc fs with non-extent file
commit 292db1bc6c105d86111e858859456bcb11f90f91 upstream.
ext4 isn't willing to map clusters to a non-extent file. Don't signal
this with an out of space error, since the FS will retry the
allocation (which didn't fail) forever. Instead, return EUCLEAN so
that the operation will fail immediately all the way back to userspace.
(The fix is either to run e2fsck -E bmap2extent, or to chattr +e the file.)
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext4/indirect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c index c30cbe291e30..fed626faeecd 100644 --- a/fs/ext4/indirect.c +++ b/fs/ext4/indirect.c @@ -576,7 +576,7 @@ int ext4_ind_map_blocks(handle_t *handle, struct inode *inode, EXT4_FEATURE_RO_COMPAT_BIGALLOC)) { EXT4_ERROR_INODE(inode, "Can't allocate blocks for " "non-extent mapped inodes with bigalloc"); - return -ENOSPC; + return -EUCLEAN; } goal = ext4_find_goal(inode, map->m_lblk, partial); |