diff options
| author | Peng Tao <tao.peng@primarydata.com> | 2014-11-05 22:36:50 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-11-19 18:38:20 +0100 |
| commit | d0c8187c16fa9294a2ff8fbbe85c15776ca3fa72 (patch) | |
| tree | 223a8e30ce8b0dad87ac3ded457db39948cd4967 /fs | |
| parent | 9fb5f68e66142ca36cb0958a12b2f1af47a723bc (diff) | |
| download | lwn-d0c8187c16fa9294a2ff8fbbe85c15776ca3fa72.tar.gz lwn-d0c8187c16fa9294a2ff8fbbe85c15776ca3fa72.zip | |
nfs: fix pnfs direct write memory leak
commit 8c393f9a721c30a030049a680e1bf896669bb279 upstream.
For pNFS direct writes, layout driver may dynamically allocate ds_cinfo.buckets.
So we need to take care to free them when freeing dreq.
Ideally this needs to be done inside layout driver where ds_cinfo.buckets
are allocated. But buckets are attached to dreq and reused across LD IO iterations.
So I feel it's OK to free them in the generic layer.
Signed-off-by: Peng Tao <tao.peng@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/direct.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index af5f3ffcb157..d751a2383c24 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c @@ -179,6 +179,7 @@ static void nfs_direct_req_free(struct kref *kref) { struct nfs_direct_req *dreq = container_of(kref, struct nfs_direct_req, kref); + nfs_free_pnfs_ds_cinfo(&dreq->ds_cinfo); if (dreq->l_ctx != NULL) nfs_put_lock_context(dreq->l_ctx); if (dreq->ctx != NULL) |